To examine the association between pre-diagnostic serum carotenoid levels and lung cancer risk and the effects of alcohol intake on the carotenoid-lung cancer relationship, we conducted a case-control study in an occupational cohort from the Yunnan Tin Corporation in China. During 6 years of follow-up, 339 cases of confirmed lung cancer were diagnosed. Among these cases, those who donated pre-diagnostic blood (n = 108) were eligible for this study. For each case, two individuals alive and free of cancer at the time of case diagnosis, matched on age, sex, and date of blood collection, were selected as controls. Serum beta-carotene (odds ratios (ORs) for tertiles: 1, 1.3, 2.0) and beta-cryptoxanthin (ORs for tertiles: 1, 1.8, 2.9) levels were positively associated with lung cancer risk after adjustment for tobacco use and radon exposure. Among alcohol drinkers, higher serum carotenoid levels were significantly associated with increased lung cancer risk (alpha-carotene OR 2.2, 95% confidence interval (CI) 1.1-4.4, beta-carotene OR 7.6, 95% CI 3.1-18.6, lutein/zeaxanthin OR 2.3, 95% CI 1.2-6.6 and beta-cryptoxanthin OR 7.6, 95% CI 2.7-21.5). Conversely, risk estimates among non-drinkers suggest a possible protective association for higher carotenoid levels.